Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish events to timeline service, controller gets timeline from service #3639

Closed
wants to merge 1 commit into from
Closed

feat: publish events to timeline service, controller gets timeline from service #3639

wants to merge 1 commit into from

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Dec 5, 2024 •
edited
Loading

  • Removes old sql queries
  • Controller passes console timeline queries to console service
  • Timeline event publishing happens with convenience func: timeline.Publish(ctx, event), and all event creation is moved to it

fixes #3622
fixes #3623
fixes #3633
fixes #3625

@matt2e matt2e requested review from a team and alecthomas as code owners December 5, 2024 05:27
@matt2e matt2e requested review from wesbillman and removed request for a team December 5, 2024 05:27
@matt2e matt2e marked this pull request as draft December 5, 2024 05:27
@matt2e matt2e force-pushed the matt2e/publish-to-timeline-service branch from dec533c to 27436cb Compare December 5, 2024 05:27
@ftl-robot ftl-robot mentioned this pull request Dec 5, 2024
Open
@matt2e matt2e force-pushed the matt2e/publish-to-timeline-service branch 2 times, most recently from 8666d08 to 6765929 Compare December 5, 2024 05:39
@matt2e matt2e changed the title feat: other components call timeline service to publish and get events feat: publish events to timeline service, controller gets timeline from service Dec 5, 2024
@matt2e matt2e force-pushed the matt2e/publish-to-timeline-service branch 5 times, most recently from 6d039d1 to d903fe9 Compare December 5, 2024 06:53
@worstell worstell force-pushed the matt2e/publish-to-timeline-service branch 4 times, most recently from 512cf67 to 6a9c4b9 Compare December 5, 2024 17:10
@worstell worstell marked this pull request as ready for review December 5, 2024 17:22
@worstell worstell self-requested a review December 5, 2024 17:22
@worstell worstell force-pushed the matt2e/publish-to-timeline-service branch from 6a9c4b9 to 58f3b79 Compare December 5, 2024 18:06
@worstell worstell requested a review from a team as a code owner December 5, 2024 19:16
@worstell worstell force-pushed the matt2e/publish-to-timeline-service branch from db50b14 to 9d2fe34 Compare December 5, 2024 19:31
@worstell worstell requested a review from a team as a code owner December 5, 2024 19:31
@worstell worstell force-pushed the matt2e/publish-to-timeline-service branch 5 times, most recently from 2e33775 to e902b60 Compare December 5, 2024 20:45
@worstell worstell force-pushed the matt2e/publish-to-timeline-service branch 3 times, most recently from be6997a to 994f440 Compare December 5, 2024 21:27
@matt2e matt2e mentioned this pull request Dec 5, 2024
Merged
matt2e added a commit that referenced this pull request Dec 6, 2024
@matt2e
feat: add timeline service to local k8s (#3647)
1b9345b 
closes #3620

Split this out from #3639
@worstell did all the work on this
@matt2e matt2e marked this pull request as draft December 6, 2024 00:22
@matt2e matt2e mentioned this pull request Dec 6, 2024
Merged
matt2e added a commit that referenced this pull request Dec 6, 2024
@matt2e
feat: publish timeline events with new service (#3649)
72efa87 
Timeline event publishing happens with convenience func:
`timeline.Publish(ctx, event)`, and all event creation is moved over to
it.

Timeline tests have been in this PR but [will come back
soon](#3634).

This PR is split from #3639.
Thanks @worstell for working on this one with me.

closes #3622
@matt2e matt2e force-pushed the matt2e/publish-to-timeline-service branch 3 times, most recently from 2b1dde0 to 83246ed Compare December 6, 2024 03:41
@matt2e
wip
09ddae1 
# Conflicts:
#	backend/controller/console/console.go
#	backend/controller/controller.go
#	backend/controller/timeline/events_async.go
#	backend/controller/timeline/events_call.go
#	backend/controller/timeline/events_cron.go
#	backend/controller/timeline/events_ingress.go
#	backend/controller/timeline/events_log.go
#	backend/controller/timeline/events_pubsub_consume.go
#	backend/controller/timeline/events_pubsub_publish.go
#	backend/controller/timeline/timeline.go

# Conflicts:
#	backend/controller/controller.go
#	backend/controller/timeline/timeline.go

# Conflicts:
#	backend/controller/console/console.go
@matt2e matt2e force-pushed the matt2e/publish-to-timeline-service branch from 83246ed to 09ddae1 Compare December 6, 2024 04:01
@matt2e matt2e closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@wesbillman wesbillman Awaiting requested review from wesbillman wesbillman was automatically assigned from TBD54566975/ftl-frontend-team

@worstell worstell Awaiting requested review from worstell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@matt2e